Fix dict_delete_get_min and max functions #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I checked all functions in stdlib, and all of the functions that returns a boolean have a ? suffix, except for dict_delete_get_min and dict_delete_get_max functions, which together with udict and idict versions and modifying versions are a total of 12 functions. Also removed `::` from modifying versions of these functions since this was the only place in stdlib that they were used, and it makes them more similar to non-modifying versions. It should not be a breaking change, since old users are using a copy of this stdlib and will not be affected, unless they update their library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked all functions in stdlib, and all of the functions that returns a boolean have a ? suffix, except for dict_delete_get_min and dict_delete_get_max functions, which together with udict and idict versions and modifying versions are a total of 12 functions.
Also removed
::from modifying versions of these functions since this was the only place in stdlib that they were used, and it makes them more similar to non-modifying versions.It should not be a breaking change, since old users are using a copy of this stdlib and will not be affected, unless they update their library.